-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "always" approval policy #806
Conversation
Revert approval requeue duration default
Looks good. I'll download it and tryto run the e2e tests locally. |
Remove commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good. I am approving, but I do think it's not necessary to include the additional details in the event messages; the event is already attached to the package revision. I am unsure of whether there are optimizations in the event handling that may be defeated by adding additional info in the message rather than a static message. I guess it's still static, for that PackageRevision, so maybe it's ok.
Hi @johnbelamaric thanks for reviewing. Ye I just added the additional info for logging/debugging purposes. If you think it doesn't belong in the event, then maybe we should add it to a logger somewhere. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update pkgrev.get to use api Reader to bypass cache
Additional logging
Update kyaml versions to sync with porch version