Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "always" approval policy #806

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Sep 2, 2024

Update pkgrev.get to use api Reader to bypass cache
Additional logging
Update kyaml versions to sync with porch version

Revert approval requeue duration default
@liamfallon
Copy link
Member

Looks good. I'll download it and tryto run the e2e tests locally.

Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good. I am approving, but I do think it's not necessary to include the additional details in the event messages; the event is already attached to the package revision. I am unsure of whether there are optimizations in the event handling that may be defeated by adding additional info in the message rather than a static message. I guess it's still static, for that PackageRevision, so maybe it's ok.

@nephio-prow nephio-prow bot added the approved label Sep 10, 2024
@efiacor
Copy link
Contributor Author

efiacor commented Sep 11, 2024

Ok, looks good. I am approving, but I do think it's not necessary to include the additional details in the event messages; the event is already attached to the package revision. I am unsure of whether there are optimizations in the event handling that may be defeated by adding additional info in the message rather than a static message. I guess it's still static, for that PackageRevision, so maybe it's ok.

Hi @johnbelamaric thanks for reviewing. Ye I just added the additional info for logging/debugging purposes. If you think it doesn't belong in the event, then maybe we should add it to a logger somewhere.

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnbelamaric,liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 7e451cb into nephio-project:main Sep 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants