Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable devcontainers #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

electrocucaracha
Copy link
Member

This provisioning option offers the alternative to create Sandbox environments on GitHub Cloud. This feature can be limited in HW resources to some users based on their GH account.

@nephio-prow nephio-prow bot requested review from aravind254 and vjayaramrh June 12, 2023 23:06
@electrocucaracha electrocucaracha force-pushed the add_devcontainers_support branch 7 times, most recently from fd90929 to 638ad32 Compare June 13, 2023 01:11
e2e/provision/README.md Outdated Show resolved Hide resolved
@@ -1,5 +1,7 @@
# Quick Start for GCE

[![Createte a Sandbox in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://github.com/codespaces/new?repo=nephio-project/test-infra)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be executed in codespace, I think that we must check that the scripts are running fine in this environment. We probably need to create a user

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually tested here, unfortunately not all the GitHub accounts has enabled that flavor.

@electrocucaracha electrocucaracha force-pushed the add_devcontainers_support branch 2 times, most recently from f48da1c to c2024bd Compare June 14, 2023 23:59
@electrocucaracha electrocucaracha force-pushed the add_devcontainers_support branch from c2024bd to a48431f Compare June 21, 2023 14:15
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha electrocucaracha force-pushed the add_devcontainers_support branch from a48431f to df80167 Compare July 14, 2023 01:09
@electrocucaracha
Copy link
Member Author

/retest

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants