Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2DGS for Correct Normal and Median Depth Calculation #430

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

khokao
Copy link
Contributor

@khokao khokao commented Sep 30, 2024

Fixes the calculation of normal and median depths in 2DGS.

issue: #425

@liruilong940607
Copy link
Collaborator

liruilong940607 commented Sep 30, 2024

Thank for the fix! Would you mind run the formatter to pass the test?

pip install black==22.3.0
black . gsplat/ tests/ examples/ profiling/

@khokao
Copy link
Contributor Author

khokao commented Sep 30, 2024

@liruilong940607
Thanks for the review!

Would you mind run the formatter to pass the test?

I have formatted the code 🙏
f839a41

@liruilong940607 liruilong940607 merged commit 0a200cd into nerfstudio-project:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants