Add compile-time checks w.r.t. is_primary or existence of get_secondary_event()
#3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffgaga
force-pushed
the
draft_compiletime_checks
branch
from
25352a8
to
e217e3c
Compare
terhorstd
added
S: Normal
terhorstd
changed the title
is_primary or existance of get_secondary_event()
otcathatsya
approved these changes
Jun 24, 2024
| constexpr bool has_get_secondary_event = has_get_secondary_event_t< ConnectionT >::value; | ||
| static_assert( | ||
| is_primary xor has_get_secondary_event, "Non-primary connections have to provide get_secondary_event()" ); | ||
| if constexpr ( ( not is_primary ) and has_get_secondary_event ) |
There was a problem hiding this comment.
should be sufficient to only check one of the conditions after the assert
Edit: if this was accidentally called on a primary event synapse, would it be possible to reach the nullptr? Would it be safer to provide an error message there?
There was a problem hiding this comment.
Should be sufficient, but also doesn't hurt to check for both at compile time, right?
heplesser
changed the title
is_primary or existance of get_secondary_event()is_primary or existence of get_secondary_event()
JanVogelsang
suggested changes
Jun 25, 2024
| constexpr bool has_get_secondary_event = has_get_secondary_event_t< ConnectionT >::value; | ||
| static_assert( | ||
| is_primary xor has_get_secondary_event, "Non-primary connections have to provide get_secondary_event()" ); | ||
| if constexpr ( ( not is_primary ) and has_get_secondary_event ) |
There was a problem hiding this comment.
Should be sufficient, but also doesn't hurt to check for both at compile time, right?
| else | ||
| { | ||
| // unreachable code | ||
| return nullptr; |
There was a problem hiding this comment.
Suggested change
| return nullptr; | |
| UnsupportedEvent( "Using secondary events on primary connections is not possible. Secondary connections must implement get_secondary_event!" ); |
|
@muffgaga Could you respond to the remarks in the code review? Also, could you merge master into your branch and fix the conflicts that have arisen since you created this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is not a polished commit, but rather just a draft showing that some more compile-time checking of the interfaces is possible without any restructuring. (Cf. discussion in PR #2988).
IS_PRIMARYproperty, we now can dropConnection::get_secondary_event(), which could only be reached by illegal code.not IS_PRIMARYand the existence of the derived Connection'sget_secondary_event— and it provides a compile-time error message in cases where this isn't the case.