feat: add parent/k8sState hostname value (#447)

* feat: add parent/k8sState hostname value * format readme config table * update docs
netdata · Oct 22, 2024 · 78f6db3 · 78f6db3
1 parent ce478a1
commit 78f6db3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/charts/netdata/README.md b/charts/netdata/README.md
@@ -127,6 +127,7 @@ The following table lists the configurable parameters of the netdata chart and t
 | `restarter.startingDeadlineSeconds`           | Optional deadline in seconds for starting the job if it misses scheduled time for any reason                                                           | `60`                                                                                    |
 | `restarter.successfulJobsHistoryLimit`        | The number of successful finished jobs to retain                                                                                                       | `3`                                                                                     |
 | `restarter.failedJobsHistoryLimit`            | The number of failed finished jobs to retain                                                                                                           | `3`                                                                                     |
+| `parent.hostname`                             | Parent node hostname                                                                                                                                   | `netdata-parent`                                                                        |
 | `parent.enabled`                              | Install parent Deployment to receive metrics from children nodes                                                                                       | `true`                                                                                  |
 | `parent.port`                                 | Parent's listen port                                                                                                                                   | `19999`                                                                                 |
 | `parent.resources`                            | Resources for the parent deployment                                                                                                                    | `{}`                                                                                    |
@@ -162,7 +163,8 @@ The following table lists the configurable parameters of the netdata chart and t
 | `parent.claiming.room`                        | Comma separated list of claim rooms IDs                                                                                                                | `""`                                                                                    |
 | `parent.extraVolumeMounts`                    | Additional volumeMounts to add to the parent pods                                                                                                      | `[]`                                                                                    |
 | `parent.extraVolumes`                         | Additional volumes to add to the parent pods                                                                                                           | `[]`                                                                                    |
-| `k8sState.enabled`                            | Install this Deployment to gather data from K8s cluster                                                                                                | `true`                                                                                   |
+| `k8sState.hostname`                           | K8s state node hostname                                                                                                                                | `netdata-k8s-state`                                                                     |
+| `k8sState.enabled`                            | Install this Deployment to gather data from K8s cluster                                                                                                | `true`                                                                                  |
 | `k8sState.port`                               | Listen port                                                                                                                                            | `service.port` (Same as parent's listen port)                                           |
 | `k8sState.resources`                          | Compute resources required by this Deployment                                                                                                          | `{}`                                                                                    |
 | `k8sState.livenessProbe.initialDelaySeconds`  | Number of seconds after the container has started before liveness probes are initiated                                                                 | `0`                                                                                     |

diff --git a/charts/netdata/values.yaml b/charts/netdata/values.yaml
@@ -106,6 +106,7 @@ notifications:
     recipient: ""
 
 parent:
+  hostname: "netdata-parent"
   enabled: true
   port: 19999
   resources: {}
@@ -174,7 +175,7 @@ parent:
       path: /etc/netdata/netdata.conf
       data: |
         [global]
-          hostname = netdata-parent
+          hostname = {{ .Values.parent.hostname }}
         [db]
           mode = dbengine
 
@@ -380,6 +381,7 @@ child:
     #     path: /
 
 k8sState:
+  hostname: "netdata-k8s-state"
   enabled: true
   port: "{{ .Values.parent.port }}"
 
@@ -435,7 +437,7 @@ k8sState:
       path: /etc/netdata/netdata.conf
       data: |
         [global]
-          hostname = netdata-k8s-state
+          hostname = {{ .Values.k8sState.hostname }}
         [db]
           mode = ram
         [health]