Skip to content

Commit

Permalink
fix: getContext() should be sync (#222)
Browse files Browse the repository at this point in the history
* fix: getContext() should be sync

* test: update assertion after demo site code change
  • Loading branch information
pieh authored Nov 19, 2024
1 parent 795c16c commit 1cb569c
Show file tree
Hide file tree
Showing 13 changed files with 717 additions and 3,860 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ netlify serve
```
### App Engine Developer Preview usage with Angular@19

If you opt into the App Engine Developer Preview accessing `Request` and `Context` objects is streamlined. Instead of custom Netlify prefixed providers, you should use the standardized injection tokens for those provided by `@angular/ssr` instead:
If you opt into the App Engine Developer Preview accessing `Request` and `Context` objects is streamlined. Instead of custom Netlify prefixed providers, you should use the standardized injection tokens for those provided by `@angular/core` instead:

```diff
+import { REQUEST, REQUEST_CONTEXT } from '@angular/ssr/tokens'
+import { REQUEST, REQUEST_CONTEXT } from '@angular/core'
import type { Context } from "@netlify/edge-functions"

export class FooComponent {
Expand Down
2 changes: 1 addition & 1 deletion demo.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ test('edge function config', async () => {
'/favicon.ico',
'/heroes/index.html',
'/index.csr.html',
'/main-UP4QHVAQ.js',
'/main-KVCR6MBP.js',
'/polyfills-FFHMD2TL.js',
'/styles-5INURTSO.css',
'/heroes',
Expand Down
Loading

0 comments on commit 1cb569c

Please sign in to comment.