Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump angular@19 from rc to stable #227

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: bump angular@19 from rc to stable #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c79b6
chore: bump angular@19 from rc to stable
pieh Nov 19, 2024
33f4cf5
test: mask file hashes to not have to update assertion everytime depe…
pieh Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions demo.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,16 @@ import { test } from 'node:test'
test('edge function config', async () => {
const { config } = await import('./demo/.netlify/edge-functions/angular-ssr/angular-ssr.mjs')

assert.deepEqual(config.excludedPath, [
const excludedPathsWithMaskedHashes = config.excludedPath.map((path) => path.replace(/-[A-Z\d]{8}\./, '-HASHHASH.'))

assert.deepEqual(excludedPathsWithMaskedHashes, [
'/.netlify/*',
'/favicon.ico',
'/heroes/index.html',
'/index.csr.html',
'/main-KVCR6MBP.js',
'/polyfills-FFHMD2TL.js',
'/styles-5INURTSO.css',
'/main-HASHHASH.js',
'/polyfills-HASHHASH.js',
'/styles-HASHHASH.css',
'/heroes',
])
Comment on lines +7 to 18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating this assertion is really annoying so I mask actual hashes with HASHHASH (matching hash length) - we don't necesairly care about concrete hashes - just that we exclude prerendered content from edge function paths

})
254 changes: 127 additions & 127 deletions demo/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

26 changes: 13 additions & 13 deletions demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^19.0.0-rc.3",
"@angular/common": "^19.0.0-rc.3",
"@angular/compiler": "^19.0.0-rc.3",
"@angular/core": "^19.0.0-rc.3",
"@angular/forms": "^19.0.0-rc.3",
"@angular/platform-browser": "^19.0.0-rc.3",
"@angular/platform-browser-dynamic": "^19.0.0-rc.3",
"@angular/platform-server": "^19.0.0-rc.3",
"@angular/router": "^19.0.0-rc.3",
"@angular/ssr": "^19.0.0-rc.3",
"@angular/animations": "^19.0.0",
"@angular/common": "^19.0.0",
"@angular/compiler": "^19.0.0",
"@angular/core": "^19.0.0",
"@angular/forms": "^19.0.0",
"@angular/platform-browser": "^19.0.0",
"@angular/platform-browser-dynamic": "^19.0.0",
"@angular/platform-server": "^19.0.0",
"@angular/router": "^19.0.0",
"@angular/ssr": "^19.0.0",
"@netlify/angular-runtime": "file:..",
"@netlify/edge-functions": "^2.11.1",
"express": "^4.21.0",
Expand All @@ -29,9 +29,9 @@
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^19.0.0-rc.3",
"@angular/cli": "^19.0.0-rc.3",
"@angular/compiler-cli": "^19.0.0-rc.3",
"@angular-devkit/build-angular": "^19.0.0",
"@angular/cli": "^19.0.0",
"@angular/compiler-cli": "^19.0.0",
"@types/express": "^4.17.21",
"@types/jasmine": "~5.1.0",
"@types/node": "^18.19.13",
Expand Down
Loading
Loading