Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove read-pkg-up #4043

Closed
wants to merge 1 commit into from
Closed

chore(deps): remove read-pkg-up #4043

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 15, 2022

Refs #3941.

Note:

Opening this for feedback. I have tried to make this foolproof, but it might not be 100% the same, for example you might not want to throw an error if JSON.parse fails here, so, I'll let you decide. :)

PS. I haven't checked if there's similar code in other parts of the codebase. If so, it's probably best abstracting this, using it everywhere and testing it properly.


If this lands, the same should be made in the remaining 2 production packages that depend on read-pkg-up:

C:\Users\xmr\Desktop\cli>npm ls read-pkg-up
netlify-cli@8.9.0 C:\Users\xmr\Desktop\cli
+-- @netlify/build@26.1.3
| `-- read-pkg-up@7.0.1
`-- @netlify/framework-info@8.0.1
  `-- read-pkg-up@7.0.1

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jan 17, 2022
@erezrokah
Copy link
Contributor

Thanks @XhmikosR, I'm not sure we'd like to inline this dependency.
read-pkg-up is small, well maintained, comes with tests and types.

Also it uses read-pkg that has other benefits like data normalization, see https://github.com/sindresorhus/read-pkg#why

Closing this for now. Please comment if you think I got this wrong.

@erezrokah erezrokah closed this Jan 25, 2022
@XhmikosR XhmikosR deleted the rm-read-pkg-up branch January 25, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants