Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace promisify with fs/promises version on convert.js #522

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Jan 3, 2024

refactor: replace make-dir with fs/mkdir

  • replace functionality related to create a directory
  • remove dependency make-dir no longer needed

Related to netlify/cli#3941

hereje added 2 commits January 2, 2024 19:33
- replace functionality related to create a directory
- remove dependency no longer needed
@hereje hereje requested a review from a team as a code owner January 3, 2024 01:36
src/convert.js Outdated Show resolved Hide resolved
src/convert.js Outdated Show resolved Hide resolved
@hereje hereje changed the title Refactor/replace mkdir with fs mkdir refactor: replace promisify with fs/promises version on convert.js Jan 4, 2024
src/convert.js Outdated Show resolved Hide resolved
Copy link
Contributor

@kitop kitop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. And then I'm curious if there's a way to make the package.json have less changes. Since there's a lot because it's changing from V1 to V3 - would it be possible to have it keep the old format? It'd be nicer to change the format in a specific PR.

@hereje
Copy link
Contributor Author

hereje commented Jan 8, 2024

One small comment. And then I'm curious if there's a way to make the package.json have less changes. Since there's a lot because it's changing from V1 to V3 - would it be possible to have it keep the old format? It'd be nicer to change the format in a specific PR.

Sorry, My mistake.

I will do it through:

npm install --lockfile-version 1

hereje added 2 commits January 8, 2024 18:01
- keep dependencies listed on package.json
- installation through: npm install --lockfile-version 1
@kitop
Copy link
Contributor

kitop commented Jan 15, 2024

@hereje thanks for the update! Unfortunately, seems like there's still a lot of additions to the package-lock.json, like adding webpack, source-map and others that were not there before.

I've tried the same change in the package.json locally (remove mk-dir and add the engines definition) and here's the diff I get: https://gist.github.com/kitop/9b53d60e4b2650bc0a03f6036ac76477

Any reason why the other dependencies where added? I'd like to keep the package-lock.json as clean as possible.

- update package-lock.json file with a clean installation
@hereje hereje force-pushed the refactor/replace-mkdir-with-fs-mkdir branch from 5a30d36 to 551cbc0 Compare January 15, 2024 17:10
@hereje
Copy link
Contributor Author

hereje commented Jan 15, 2024

@hereje thanks for the update! Unfortunately, seems like there's still a lot of additions to the package-lock.json, like adding webpack, source-map and others that were not there before.

I've tried the same change in the package.json locally (remove mk-dir and add the engines definition) and here's the diff I get: https://gist.github.com/kitop/9b53d60e4b2650bc0a03f6036ac76477

Any reason why the other dependencies where added? I'd like to keep the package-lock.json as clean as possible.

Yeah, it seems I poluted the file when I made a dependency install.

I have fixed the issue.

@kitop kitop enabled auto-merge January 15, 2024 17:50
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for open-api ready!

Name Link
🔨 Latest commit 551cbc0
🔍 Latest deploy log https://app.netlify.com/sites/open-api/deploys/65a5671930912d0008d1d6d3
😎 Deploy Preview https://deploy-preview-522--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kitop kitop merged commit 59cf06d into netlify:master Jan 16, 2024
15 checks passed
@hereje hereje deleted the refactor/replace-mkdir-with-fs-mkdir branch January 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants