-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace promisify with fs/promises version on convert.js #522
refactor: replace promisify with fs/promises version on convert.js #522
Conversation
- replace functionality related to create a directory
- remove dependency no longer needed
- replace promisified versions of fs with fs/promises
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. And then I'm curious if there's a way to make the package.json have less changes. Since there's a lot because it's changing from V1 to V3 - would it be possible to have it keep the old format? It'd be nicer to change the format in a specific PR.
Sorry, My mistake. I will do it through:
|
- keep dependencies listed on package.json - installation through: npm install --lockfile-version 1
@hereje thanks for the update! Unfortunately, seems like there's still a lot of additions to the package-lock.json, like adding webpack, source-map and others that were not there before. I've tried the same change in the package.json locally (remove Any reason why the other dependencies where added? I'd like to keep the package-lock.json as clean as possible. |
- update package-lock.json file with a clean installation
5a30d36
to
551cbc0
Compare
Yeah, it seems I poluted the file when I made a dependency install. I have fixed the issue. |
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refactor: replace make-dir with fs/mkdir
Related to netlify/cli#3941