Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upside down and performance issues all in one #24

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

shunia
Copy link
Contributor

@shunia shunia commented Jul 14, 2020

It's been a long time since I work with Unity and WebP, thanks for this library and it has helped a lot. And when I finally solved the issues I created, I thought I should give my solution back here. So I organized my code and create the pull request here.

This pr can not be merged, just for the library owners' information.

This pr can:

  1. Fix upside down problem: Animated WebP parse error on MacOS Editor and Android #18 (comment)
  2. Fix performance issue (10x faster decoding): Pixel copy to flip texture is too slow, WebPDecoderOptions.flip should be used, but how? #21
  3. Offer render ability for further extending

And because I'm no longer working on Unity, and Unity just crashes my laptop when opening, this pr can not:

  1. Run!!! (I can not make the project run because when I open Unity and my laptop just crashes), so the codes may not able to passed the build;
  2. Be used directly: The actual loading logic should be implemented (WebPLoader.cs#32)

Added example for simple usage;
Adjusted the comments for easier understandings;
@netpyoung
Copy link
Owner

You found the way. good job and thank you pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants