Add abstract base class OHttpCrypto to share code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We can share code between OHttpCryptoSender and OHttpCryptoReceiver by introducing an abstract base class. This also allows us to merge the OHttpCryptoUtils into this abstract base class. Modifications: - Introduce abstract base class and extend it - Add javadocs Result: Share code and add docs
normanmaurer
force-pushed
the
abstract_class
branch
from
7a835e3
to
c0824d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We can share code between OHttpCryptoSender and OHttpCryptoReceiver by introducing an abstract base class. This also allows us to merge the OHttpCryptoUtils into this abstract base class.
Modifications:
Result:
Share code and add docs