adding juniper_junos_show_system_processes_brief.textfsm support #1922

jnicholson56 · 2024-12-02T22:44:25Z

adding juniper_junos_show_system_processes_brief.textfsm support

jmcgill298

Thanks @jnicholson56 just a couple of minor adjustments.

jmcgill298 · 2024-12-04T15:24:45Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+Value MEM_ACTIVE (\d*\D*\d*)
+Value MEM_FREE (\d*\D*\d*)
+Value MEM_USED (\d*\D*\d*)
+Value MEM_BUFFER (\d*\D*\d*)


Suggested change

Value MEM_ACTIVE (\d*\D*\d*)

Value MEM_FREE (\d*\D*\d*)

Value MEM_USED (\d*\D*\d*)

Value MEM_BUFFER (\d*\D*\d*)

Value MEMORY_ACTIVE (\d*\D*\d*)

Value MEMORY_FREE (\d*\D*\d*)

Value MEMORY_USED (\d*\D*\d*)

Value MEMORY_BUFFER (\d*\D*\d*)

We should keep this consistent

jmcgill298 · 2024-12-04T15:25:29Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+  ^top\s*
+  ^Tasks:\s*
+  ^\%Cpu
+  ^${MEMORY_FORMAT}iB\s*Mem\s*:\s*${MEM_ACTIVE}\s*total,\s*${MEM_FREE}\s*free,\s*${MEM_USED}\s*used,\s*${MEM_BUFFER}\s*buff/cache\s*


Suggested change

^${MEMORY_FORMAT}iB\s*Mem\s*:\s*${MEM_ACTIVE}\s*total,\s*${MEM_FREE}\s*free,\s*${MEM_USED}\s*used,\s*${MEM_BUFFER}\s*buff/cache\s*

^${MEMORY_FORMAT}i*B\s*Mem\s*:\s*${MEMORY_ACTIVE}\s*total,\s*${MEMORY_FREE}\s*free,\s*${MEMORY_USED}\s*used,\s*${MEMORY_BUFFER}\s*buff/cache\s*

I think the i could not be present depending on what storage is being used

jmcgill298 · 2024-12-04T15:35:50Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+  ^Tasks:\s*
+  ^\%Cpu
+  ^${MEMORY_FORMAT}iB\s*Mem\s*:\s*${MEM_ACTIVE}\s*total,\s*${MEM_FREE}\s*free,\s*${MEM_USED}\s*used,\s*${MEM_BUFFER}\s*buff/cache\s*
+  ^${SWAP_FORMAT}iB\s*Swap:\s*${SWAP_TOTAL}\s*total,\s*${SWAP_FREE}\s*free,\s*${SWAP_USED}\s*used\.\s*${SWAP_AVAIL}\s*avail\s*Mem\s* -> Record


Suggested change

^${SWAP_FORMAT}iB\s*Swap:\s*${SWAP_TOTAL}\s*total,\s*${SWAP_FREE}\s*free,\s*${SWAP_USED}\s*used\.\s*${SWAP_AVAIL}\s*avail\s*Mem\s* -> Record

^${SWAP_FORMAT}i*B\s*Swap:\s*${SWAP_TOTAL}\s*total,\s*${SWAP_FREE}\s*free,\s*${SWAP_USED}\s*used\.\s*${SWAP_AVAIL}\s*avail\s*Mem\s* -> Record

jmcgill298 · 2024-12-04T15:36:22Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+  ^{master}
+  ^. -> Error
+
+EOF


Suggested change

EOF

I don't think the EOF is necessary since there aren't any FillDowns

jmcgill298 · 2024-12-04T15:36:31Z

tests/juniper_junos/show_system_processes_brief/juniper_junos_show_system_processes_brief.raw

+Tasks: 407 total,   1 running, 406 sleeping,   0 stopped,   0 zombie
+%Cpu(s):  2.1 us,  2.7 sy,  0.0 ni, 94.6 id,  0.0 wa,  0.3 hi,  0.3 si,  0.0 st
+MiB Mem : 128191.6 total,  93230.9 free,   6286.2 used,  28674.5 buff/cache
+MiB Swap:   4096.0 total,   1131.7 free,   2964.2 used. 119812.1 avail Mem


Suggested change

MiB Swap: 4096.0 total, 1131.7 free, 2964.2 used. 119812.1 avail Mem

MiB Swap: 4096.0 total, 1131.7 free, 2964.2 used. 119812.1 avail Mem

jmcgill298 · 2024-12-04T15:37:32Z

tests/juniper_junos/show_system_processes_brief/juniper_junos_show_system_processes_brief.yml

+  - mem_active: "31554.4"
+    mem_buffer: "3661.7"
+    mem_free: "17292.4"
+    mem_used: "10600.3"
+    memory_format: "M"
+    node: "fpc0"
+    swap_avail: "19854.3"
+    swap_format: "M"
+    swap_free: "100.0"
+    swap_total: "100.0"
+    swap_used: "0.0"
+  - mem_active: "128191.6"
+    mem_buffer: "45096.8"
+    mem_free: "65543.4"
+    mem_used: "17551.4"
+    memory_format: "M"
+    node: "re0"
+    swap_avail: "108490.7"
+    swap_format: "M"
+    swap_free: "8192.0"
+    swap_total: "8192.0"
+    swap_used: "0.0"
+  - mem_active: "128191.6"
+    mem_buffer: "28674.5"
+    mem_free: "93230.9"
+    mem_used: "6286.2"


Suggested change

- mem_active: "31554.4"

mem_buffer: "3661.7"

mem_free: "17292.4"

mem_used: "10600.3"

memory_format: "M"

node: "fpc0"

swap_avail: "19854.3"

swap_format: "M"

swap_free: "100.0"

swap_total: "100.0"

swap_used: "0.0"

- mem_active: "128191.6"

mem_buffer: "45096.8"

mem_free: "65543.4"

mem_used: "17551.4"

memory_format: "M"

node: "re0"

swap_avail: "108490.7"

swap_format: "M"

swap_free: "8192.0"

swap_total: "8192.0"

swap_used: "0.0"

- mem_active: "128191.6"

mem_buffer: "28674.5"

mem_free: "93230.9"

mem_used: "6286.2"

- memory_active: "31554.4"

memory_buffer: "3661.7"

memory_free: "17292.4"

memory_used: "10600.3"

memory_format: "M"

node: "fpc0"

swap_avail: "19854.3"

swap_format: "M"

swap_free: "100.0"

swap_total: "100.0"

swap_used: "0.0"

- memory_active: "128191.6"

memory_buffer: "45096.8"

memory_free: "65543.4"

memory_used: "17551.4"

memory_format: "M"

node: "re0"

swap_avail: "108490.7"

swap_format: "M"

swap_free: "8192.0"

swap_total: "8192.0"

swap_used: "0.0"

- memory_active: "128191.6"

memory_buffer: "28674.5"

memory_free: "93230.9"

memory_used: "6286.2"

jmcgill298 · 2024-12-04T16:05:26Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+Value SWAP_AVAIL (\d*\D*\d*)
+
+Start
+  ^-------------------------------


Suggested change

^-------------------------------

^-+\s*$$

We can match however many dashes there are

jmcgill298 · 2024-12-04T16:05:50Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+Start
+  ^-------------------------------
+  ^node:\s*${NODE}
+  ^-------------------------------


Suggested change

^-------------------------------

matched be existing regex

jmcgill298 · 2024-12-04T16:07:47Z

ntc_templates/templates/juniper_junos_show_system_processes_brief.textfsm

+  ^\%Cpu
+  ^${MEMORY_FORMAT}iB\s*Mem\s*:\s*${MEM_ACTIVE}\s*total,\s*${MEM_FREE}\s*free,\s*${MEM_USED}\s*used,\s*${MEM_BUFFER}\s*buff/cache\s*
+  ^${SWAP_FORMAT}iB\s*Swap:\s*${SWAP_TOTAL}\s*total,\s*${SWAP_FREE}\s*free,\s*${SWAP_USED}\s*used\.\s*${SWAP_AVAIL}\s*avail\s*Mem\s* -> Record
+  ^\s+\S+


Suggested change

^\s+\S+

This is a little too loose of a match, and could lead to incorrect parsing without raising an error. I don't see any example of this in the provided test case, is this something you would expect to see?

adding juniper_junos_show_system_processes_brief.textfsm support

d142cce

jnicholson56 requested review from itdependsnetworks, jmcgill298 and jvanderaa as code owners December 2, 2024 22:44

jmcgill298 requested changes Dec 4, 2024

View reviewed changes

jmcgill298 reviewed Dec 4, 2024

View reviewed changes

jmcgill298 requested changes Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding juniper_junos_show_system_processes_brief.textfsm support #1922

adding juniper_junos_show_system_processes_brief.textfsm support #1922

jnicholson56 commented Dec 2, 2024

jmcgill298 left a comment

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

jmcgill298 Dec 4, 2024

	^${MEMORY_FORMAT}iB\sMem\s:\s${MEM_ACTIVE}\stotal,\s${MEM_FREE}\sfree,\s${MEM_USED}\sused,\s${MEM_BUFFER}\sbuff/cache\s*
	^${MEMORY_FORMAT}iB\sMem\s:\s${MEMORY_ACTIVE}\stotal,\s${MEMORY_FREE}\sfree,\s${MEMORY_USED}\sused,\s${MEMORY_BUFFER}\sbuff/cache\s

	^${SWAP_FORMAT}iB\sSwap:\s${SWAP_TOTAL}\stotal,\s${SWAP_FREE}\sfree,\s${SWAP_USED}\sused\.\s${SWAP_AVAIL}\savail\sMem\s* -> Record
	^${SWAP_FORMAT}iB\sSwap:\s${SWAP_TOTAL}\stotal,\s${SWAP_FREE}\sfree,\s${SWAP_USED}\sused\.\s${SWAP_AVAIL}\savail\sMem\s -> Record

	MiB Swap: 4096.0 total, 1131.7 free, 2964.2 used. 119812.1 avail Mem
	MiB Swap: 4096.0 total, 1131.7 free, 2964.2 used. 119812.1 avail Mem

adding juniper_junos_show_system_processes_brief.textfsm support #1922

Are you sure you want to change the base?

adding juniper_junos_show_system_processes_brief.textfsm support #1922

Conversation

jnicholson56 commented Dec 2, 2024

jmcgill298 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment