create nx_version.txt #2, nx_dev_test_output.txt #3, Run timing scripts from nx-parallel #191 and creating a python script nx_tutorial_script.py #5 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
reviewed
Oct 16, 2023
| @@ -0,0 +1 @@ | |||
| print(nx.__version__) | |||
There was a problem hiding this comment.
Could you put the output of this command? Thanks!
There was a problem hiding this comment.
ok i did it already
|
hi @MridulS please help review my work nx_version.txt and nx_dev_test_output.txt |
MridulS
reviewed
Oct 19, 2023
| =============================================== short test summary info =============================================== | ||
| FAILED networkx/networkx/drawing/tests/test_pydot.py::test_pydot_issue_258 - FileNotFoundError: [WinError 2] "neato" not found in path. | ||
| FAILED networkx/networkx/drawing/tests/test_pydot.py::test_pydot_numerical_name - FileNotFoundError: [WinError 2] "dot" not found in path. | ||
| ==================== 2 failed, 5092 passed, 56 skipped, 3 xfailed, 7 warnings in 282.04s (0:04:42) ==================== |
There was a problem hiding this comment.
Thanks for this! The tests are failing. Could you look into this? You can also try removing pydot so pytest skips the tests.
There was a problem hiding this comment.
Thank you @MridulS it pass now without any fail.
please does it means i have done my first contribution already?
There was a problem hiding this comment.
Can you please update the test output file with the new output then? Thanks!
There was a problem hiding this comment.
yeah i did already and push
|
Thanks! |
|
thanks too
…On Thu, Oct 19, 2023, 10:17 AM Mridul Seth ***@***.***> wrote:
Thanks!
—
Reply to this email directly, view it on GitHub
<#251 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4PDVTYMCXWE6OJAD2RPU7LYADVZ7AVCNFSM6AAAAAA6CAQVBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGQYDCNJVGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tiwavaldese
changed the title
tiwavaldese
changed the title
tiwavaldese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created nx_version.txt #2 , nx_dev_test_output.txt #3 , Run timing scripts from nx-parallel #191 and creating a python script nx_tutorial_script.py #5