Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task#2 (Setup local development environment for NetworkX) #51

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

29riyasaxena
Copy link
Contributor

Hi! I have completed this task which was #3 . Kindly check it. @rossbar @dschult @MridulS

@MridulS
Copy link
Member

MridulS commented Apr 5, 2022

@29riyasaxena could you add the full output of pytest? Thanks!

@29riyasaxena
Copy link
Contributor Author

29riyasaxena commented Apr 5, 2022

@29riyasaxena could you add the full output of pytest? Thanks!

Hi! I have modified the output file. Please check it.

@MridulS
Copy link
Member

MridulS commented Apr 5, 2022

Thanks @29riyasaxena!

@MridulS MridulS merged commit db6a310 into networkx:main Apr 5, 2022
@29riyasaxena
Copy link
Contributor Author

Thanks @29riyasaxena!

My pleasure @MridulS ! Can you please check the other file which I have committed, I don't know why it has not gone to another PR.

@MridulS
Copy link
Member

MridulS commented Apr 5, 2022

Yeah I checked that too, it looks good to me.

It didn't go to a new PR as it's on the same branch main. It's recommended not to work on the main branch and create new branches for every PR :)

@29riyasaxena
Copy link
Contributor Author

Yeah I checked that too, it looks good to me.

It didn't go to a new PR as it's on the same branch main. It's recommended not to work on the main branch and create new branches for every PR :)

Okay thanks Sir!
Should I delete this file and create another PR for that task?

@MridulS
Copy link
Member

MridulS commented Apr 5, 2022

No need for that, it's already merged in https://github.com/networkx/outreachy/tree/main/2022-round-1/29riyasaxena

@29riyasaxena
Copy link
Contributor Author

No need for that, it's already merged in https://github.com/networkx/outreachy/tree/main/2022-round-1/29riyasaxena
Okay, thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants