Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Use datasets as expected by docs #1622

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[bug] Use datasets as expected by docs #1622

merged 1 commit into from
Feb 23, 2024

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Feb 23, 2024 •
edited
Loading

The eval docs pass in datasets whereas cli script was expecting dataset
Updated cli to accept datasets which also conforms with sparseml.evaluate
Screenshot 2024-02-23 at 4 43 21 PM

@rahul-tuli rahul-tuli mentioned this pull request Feb 23, 2024
Merged
@rahul-tuli rahul-tuli self-assigned this Feb 23, 2024
@bfineran bfineran merged commit 3da9761 into main Feb 23, 2024
12 of 13 checks passed
@bfineran bfineran deleted the evaluate-cli-to-consume-datasets branch February 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@Satrat Satrat Awaiting requested review from Satrat

@dsikka dsikka Awaiting requested review from dsikka

@horheynm horheynm Awaiting requested review from horheynm

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees

@rahul-tuli rahul-tuli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul-tuli @bfineran