Change scheme overrides priority #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the module type
bfineran
previously approved these changes
Oct 2, 2023
rahul-tuli
previously approved these changes
Oct 4, 2023
rahul-tuli
approved these changes
Oct 13, 2023
Satrat
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes scheme override priority to match first the module name and ten the module type. This allows users to combine both forms of scheme overrides in the same recipe in a useful way.
For instance, a user can override the default behavior for linear layers, but then define a different behavior for specific layers by defining overrides by name. This wasn't possible before