fix wheel build #2332
Merged
fix wheel build #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuangnm
reviewed
Jun 17, 2024
setup.py
Outdated
|
|
||
| # load and overwrite version and release info from sparseml package | ||
| exec(open(os.path.join("src", "sparseml", "version.py")).read()) | ||
| print(f"loaded version {version} from src/sparseml/version.py") | ||
| version_nm_deps = f"{version_major_minor}.0" | ||
| version_nm_deps = f"{version}.0" |
There was a problem hiding this comment.
This line should not change since version is the full version string?
There was a problem hiding this comment.
Is this the different than line 25 on the old code?
version_major_minor = version?
There was a problem hiding this comment.
From the old code you can see that it's using major.minor.0, but here in the new code {version} is the full string, so it becomes major.minor.hotfix.0?
dhuangnm
reviewed
Jun 17, 2024
bfineran
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import is_release from version.py for setup.py.
Running gdb, _generate_version didnt recognize global variables, so made sure the necessary variables are in scope.