Restore "default" Property for Recipes #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satrat
requested review from
horheynm,
bfineran,
rahul-tuli,
dsikka and
dbogunowicz
horheynm
previously approved these changes
Sep 14, 2023
horheynm
reviewed
Sep 14, 2023
horheynm
reviewed
Sep 14, 2023
horheynm
reviewed
Sep 14, 2023
bfineran
reviewed
Sep 14, 2023
bfineran
approved these changes
Sep 15, 2023
horheynm
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the SparseZoo V2 refactor, model recipes are stored in the root directory rather than a subfolder, so the Model class stored them as a List[Files] rather than a Directory. This removed the functionality to be able to reference a default recipe with recipes.default.
This PR introduces a Recipes class that restores the recipes.default functionality. PR neuralmagic/sparseml#1719 will have to be updated after this is merged to reflect the change