Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable motion clouds #59

Open
RoboDoig opened this issue Jun 4, 2024 · 5 comments
Open

Selectable motion clouds #59

RoboDoig opened this issue Jun 4, 2024 · 5 comments
Labels
Phase3 Issues for the Phase3 milestone

Comments

@RoboDoig
Copy link
Collaborator

RoboDoig commented Jun 4, 2024

Motion cloud textures will be selected from a list that is pre-loaded in TextureResources. Right now one must manually select the BindTexture source for the motion clouds. Would be good if the schema allowed named reference to the motion cloud texture selected on each block.

@ederancz
Copy link
Collaborator

ederancz commented Jul 1, 2024

This is part of the new contract.

@glopesdev glopesdev added the Phase3 Issues for the Phase3 milestone label Jul 11, 2024
@RoboDoig
Copy link
Collaborator Author

Note for me, check ranson-rig implementation for texture loading

@RoboDoig
Copy link
Collaborator Author

A related issue that will fall under this new implementation - currently the workflow assumes a hard-coded number of frames for each motion cloud. This value is used to 'wrap' the motion cloud sequence back around to the start during phase procession. The wrap value should be determined automatically or added as a parameter in the session settings. Ideally automatically.

@RoboDoig
Copy link
Collaborator Author

I've implemented the ability to select motion cloud textures by name in the schema and updated the local version of the Bonsai shaders package to allow automatic wrapping see here for longer term support for this feature.

There is still an error on the first motion cloud that is loaded, I think because I've implemented the GetTextureData operator as a source with the texture name as a parameter, somehow the initialisation order means that it tries to access the texture before the name property is updated.

@RoboDoig
Copy link
Collaborator Author

RoboDoig commented Oct 3, 2024

@EleonoraAmbrad - please see PR #85 for implementation of this. Seems to work but if you have a chance to test on one of your motion cloud experiments that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phase3 Issues for the Phase3 milestone
Projects
None yet
Development

No branches or pull requests

3 participants