Selectable motion clouds #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to define loaded texture sequences for a block in the experiment schema, relates to issue #59.
Though it was previously possible to define which motion cloud texture sequence to load on each block, there was no way to determine the length of the texture sequence at runtime in order to implement sequence wrapping in a closed loop experiment. Therefore this PR also adds a patched version of the Bonsai shaders package as a local package reference that allows for accessing texture sequence data at runtime. From this the length of the texture sequence can be accessed to implement sequence wrapping properly in each block.