Bubbling "child added" event so parents can update their own nodes/clusters in Blazor.Dagre #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their own node/cluster list. Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cluster containing a list of node is added to a parent cluster, the parent can update its own list of (all)nodes to include the ones of the child cluster.
But, before this fix, if the cluster was added to its parent before its nodes were appended, then the parent wouldn't be notified of the existence of the said nodes, making them 'unreachable'.