Replaced the name of the global variable holding the input data in the Javascript expression evaluator #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name previously chosen to hold the data passed to a expression,
input
, was too generic and might easily lead to collision with provided arguments. Therefore, it's been replaced by a less common symbol:$
. This basically allows the arguments dictionary to contain an entry with theinput
key without colliding with the data.Given the following input data:
And the expected output:
The Answer to the Ultimate Question of Life, the Universe, and Everything is 42, and foo = bar
Previously, the expression would have been:
"The Answer to the Ultimate Question of Life, the Universe, and Everything is " + input.answer + ", and foo = " + input.foo
And now is:
"The Answer to the Ultimate Question of Life, the Universe, and Everything is " + $.answer + ", and foo = " + $.foo
Alternatives providing the same output:
`The Answer to the Ultimate Question of Life, the Universe, and Everything is ${ $.answer }, and foo = ${ $.foo }`
${ "The Answer to the Ultimate Question of Life, the Universe, and Everything is " + $.answer + ", and foo = " + $.foo }
${ `The Answer to the Ultimate Question of Life, the Universe, and Everything is ${ $.answer }, and foo = ${ $.foo }` }