Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: false positives on markdown #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bug: false positives on markdown #40

wants to merge 2 commits into from

Commits on Oct 3, 2023

  1. Fix false positives against catalog headers expressed with markdown i… 

    …nstead of html, at the cost of a very unreadable regular expression.

This matches the following header:
([![Community Plus header](https://github.com/newrelic/opensource-website/raw/main/src/images/categories/Community_Plus.png)](https://opensource.newrelic.com/oss-category/#community-plus)

In addition to the prior header:
<a href="https://opensource.newrelic.com/oss-category/#community-plus"><picture><source media="(prefers-color-scheme: dark)" srcset="https://github.com/newrelic/opensource-website/raw/main/src/images/categories/dark/Community_Plus.png"><source media="(prefers-color-scheme: light)" srcset="https://github.com/newrelic/opensource-website/raw/main/src/images/categories/Community_Plus.png"><img alt="New Relic Open Source community plus project banner." src="https://github.com/newrelic/opensource-website/raw/main/src/images/categories/Community_Plus.png"></picture></a>

Apologies to future devs who have to strain their eyes to read the regular expression. It is fundamentally (A)|(B), where the contents of A and B are escaped.
    @lucasgonze
    lucasgonze committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    94e34cc View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Update every ruleset and remove that 2nd line, approach suggested in n… 

    …ewrelic#40 (comment)
    @lucasgonze
    lucasgonze committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c5b8171 View commit details
    Browse the repository at this point in the history