Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*DRAFT** ci: Revert linux deploy changes #2139

Closed
wants to merge 6 commits into from

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Dec 13, 2023

  • Reverts the changes made in ci: Update linux deploy to run debian:stable #2113, as we discovered that there is some sort of conflict with the aws cli when running on debian:stable in a container on a Github runner.
  • Modifies the deploy_agent workflow so that it checks out the repo and uses the files in the deploy folder rather than downloading those files from the build artifact uploaded from the all_solutions workflow. This was necessary to allow for testing changes to the linux deploy Dockerfile and scripts.
  • Removes the deploy folder from deploy-artifacts in the all_solutions workflow.
  • Attempts (yet again) to fix a bug in the post_deploy_agent workflow where we want the workflow to delay 5 minutes when called from another workflow but not when invoked manually.
  • Removes the (unnecessary) get-external-artifacts job from the publish_release_notes workflow and refactors the primary job to download the artifacts instead.

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down!

@codecov-commenter
Copy link

Codecov Report

Merging #2139 (d44cfbb) into main (9879e1f) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
- Coverage   81.07%   81.04%   -0.03%     
==========================================
  Files         396      396              
  Lines       24717    24717              
  Branches     2968     2968              
==========================================
- Hits        20039    20033       -6     
- Misses       3892     3896       +4     
- Partials      786      788       +2     

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr changed the title ci: Revert linux deploy changes *DRAFT** ci: Revert linux deploy changes Dec 13, 2023
@tippmar-nr tippmar-nr marked this pull request as draft December 13, 2023 21:55
@tippmar-nr
Copy link
Member Author

Abandoning this PR in favor of #2142

@tippmar-nr tippmar-nr closed this Dec 13, 2023
@tippmar-nr tippmar-nr deleted the ci/revert-linux-deploy-changes branch December 13, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants