Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Additional exception logging in ConnectionManager.Connect() #2886

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

tippmar-nr
Copy link
Member

Adds some logging in the exception handling code in ConnectionManager.Connect() which will potentially help us diagnose unexpected exceptions that cause the agent to shutdown and determine if we can handle those specific exceptions in a less ham-fisted manner.

@tippmar-nr tippmar-nr requested a review from a team as a code owner November 15, 2024 17:44
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, this looks much cleaner

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (9e77efa) to head (36bff28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
+ Coverage   81.43%   81.44%   +0.01%     
==========================================
  Files         465      465              
  Lines       29573    29561      -12     
  Branches     3275     3277       +2     
==========================================
- Hits        24082    24076       -6     
+ Misses       4693     4688       -5     
+ Partials      798      797       -1     
Flag Coverage Δ
Agent 82.38% <100.00%> (+0.01%) ⬆️
Profiler 73.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...elic/Agent/Core/DataTransport/ConnectionManager.cs 80.95% <100.00%> (+1.24%) ⬆️

... and 1 file with indirect coverage changes

@tippmar-nr tippmar-nr merged commit b2e8a16 into main Nov 15, 2024
95 checks passed
@tippmar-nr tippmar-nr deleted the chore/connect-error-logging branch November 15, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants