fix: Video source and old versions update in samples #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and versions are not compatible
…and versions are not compatible
|
|
asllop
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Looks good to me. I noticed the IMA example not generating the AD_BREAK_START and AD_BREAK_END events, though. But this is a problem I'm also seeing in the Bitmovin tracker, so I suspect there is something wrong in the video-core-js, not in the trackers.
EDIT: the AD_BREAK_START and AD_BREAK_END events are also broken in the freewheel tracker. Sent, but not when they should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated video source and library version