-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload rich document edition on reload event from webview (triggered on session expiration) #12814
Conversation
…on session expiration)
d91ed25
to
70b1597
Compare
@nicofrand Maybe you can also already open a pull request for the text part for easier testing and early review :) |
Done: nextcloud/text#5662 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
It's a bit ironic to get a survey about a pull request that did not receive any feedback… |
Anyone for a review? |
This is one of the top Nextcloud bugs for me. I encounter it multiple times a day. |
Moved to #13247, so that CI can work. |
Thanks for this fix, @nicofrand 👏 |
This fixes the android part of #12138.
The webview part needs some tweaking but can already be used with this PR for testing: https://github.com/nicofrand/nextcloud-text/commits/fixReconnect/.
I am quite new to android development and brand new to this app (thanks @juliushaertl for all the help already). I don't know if tests should be added or how to put them. I am open to discussion ofc.
To test (see #12138):