Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pause audio/video when swiping away #13499

Merged
merged 2 commits into from
Oct 2, 2024
Merged

pause audio/video when swiping away #13499

merged 2 commits into from
Oct 2, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 2, 2024 •
edited
Loading

  1. Open the app and login
  2. Select the media category
  3. Tap on any image
  4. scroll to a video and start playback (Device sound should be ON)
  5. Swipe to other file
  • Tests written, or not not needed

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13499.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

tobiasKaminsky and others added 2 commits October 1, 2024 14:45
@tobiasKaminsky @alperozturk96
pause audio/video when swiping away
fd6809c 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@alperozturk96
fix build
e1756fd 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

@tobiasKaminsky tobiasKaminsky merged commit 70be606 into master Oct 2, 2024
20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the videoPlaypack branch October 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @alperozturk96