-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Existence of Folder on RefreshFolderOperation #13744
base: master
Are you sure you want to change the base?
Conversation
alperozturk96
commented
Oct 9, 2024
•
edited
Loading
edited
- Tests written, or not not needed
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
That is not a real bugfix, but only hiding the real problem: Please check this. |
RefreshFolderOperation has 14 constructor usages, and those usages called from multiple places as well. Checking for folder existence and returning the correct result code seems reasonable until we fix the bug. This issue is likely rare and occurs only in specific scenarios, as we’ve never encountered it before. I’ve unlinked the original issue so we can track this bug separately. If you’re okay with this approach, you can review the PR. Otherwise, I can check all usages and update this PR with fix, but it may take some time. In any case, RefreshFolderOperation should either check for the existence of a nullable OCFile or not allow passing a nullable OCFile; additionally, the OCFile should not have a null remotePath. We can do the fix in separate PR or in this one. |