Check Existence of Folder on RefreshFolderOperation

[alperozturk96]

• Tests written, or not not needed

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	62	62
Dodgy code	296	296
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	6	6
Performance	53	53
Security	18	18
Total	509	509

[tobiasKaminsky]

That is not a real bugfix, but only hiding the real problem:
How can it be that parameter folder is null?

Please check this.

[alperozturk96]

That is not a real bugfix, but only hiding the real problem: How can it be that parameter folder is null?

Please check this.

RefreshFolderOperation has 14 constructor usages, and those usages called from multiple places as well. Checking for folder existence and returning the correct result code seems reasonable until we fix the bug. This issue is likely rare and occurs only in specific scenarios, as we’ve never encountered it before. I’ve unlinked the original issue so we can track this bug separately.

If you’re okay with this approach, you can review the PR. Otherwise, I can check all usages and update this PR with fix, but it may take some time.

In any case, RefreshFolderOperation should either check for the existence of a nullable OCFile or not allow passing a nullable OCFile; additionally, the OCFile should not have a null remotePath.

We can do the fix in separate PR or in this one.