Uniform icon colour

[ZetaTom]

During testing I noticed that some icons of the navigation bar were slightly off colour compared to the other icons. This change tints all navigation icons as #757575.

Similarly, the share icons had different colours, especially noticeable in dark mode. To appear uniform, the night variants were removed and the day variants adjusted to be the same colour as the other ones (#666666). (Reverted, as requested.)

Previously	With this pull request

Outdated screenshots

Previously	With this pull request

---

• Tests written, or not not needed

[jancborchardt]

@ZetaTom very nice catch! :) Just a little info – the share/link icon being white in the file list is intentional, as that denotes "Shared" items and differentiates them from the not-yet-shared items.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[tobiasKaminsky]

@ZetaTom we discussed that if tinting needs to be reverted, also mail/circles should be changed.
So, please revert tinting as requested by Jan and create a new issue/pr for the other.

[ZetaTom]

@ZetaTom we discussed that if tinting needs to be reverted, also mail/circles should be changed. So, please revert tinting as requested by Jan and create a new issue/pr for the other.

I've since reverted the changes as requested and adjusted the other icons accordingly.

[jancborchardt]

Looks good to me now, thanks @ZetaTom! :)

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	299	299
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	53	53
Security	18	18
Total	509	509