Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove last slash in url #170

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix: remove last slash in url #170

merged 3 commits into from
Dec 19, 2023

Conversation

andrey18106
Copy link
Collaborator

Resolves: #169

@andrey18106
fix: remove last slash in url
98e61e0 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
bigcat88
bigcat88 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added additional check on backend and adjusted tests to test backend part

re review yourself, maybe I missed something

@andrey18106 andrey18106 merged commit bc454ca into main Dec 19, 2023
29 checks passed
@andrey18106 andrey18106 deleted the fix-nextcloud-url-ui branch December 19, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nextcloud_url invalid default value, missing postparsing
2 participants
@andrey18106 @bigcat88