Question duplication

[KaasKop97]

• Resolves Feature request: Duplicate question #595

This implements the feature of #595.

Signed-off-by: Mitchel van Hamburg mitchelvanhamburg@posteo.net

[jotoeri]

Hey @KaasKop97,

nice start, thank you! :)
Got a few comments here, apart from that, can you please add the route to the API docs then?

Greets,
Jonas

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (817847b) 44.59% compared to head (c026583) 44.59%.
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1423   +/-   ##
=========================================
  Coverage     44.59%   44.59%           
- Complexity      653      657    +4     
=========================================
  Files            58       58           
  Lines          2563     2592   +29     
=========================================
+ Hits           1143     1156   +13     
- Misses         1420     1436   +16     

[KaasKop97]

I've applied almost all of your proposed changes except for

You don't need the return value. It's just the same as $newOption.

In the ApiController file, this is because the id is required to be there for QuestionMultiple if it's not present you'll receive errors in the javascript console.

Thanks for the thorough review though! I am a bit rusty on php and javascript :)

[jotoeri]

• Can you check the last push again, @KaasKop97 ? Currently the PR contains strange stuff and even is missing some of your changes.
• We try to keep a clean git history on forms. Can you rebase and squash your commits instead of the merge, please?

---

this is because the id is required to be there for QuestionMultiple if it's not present you'll receive errors in the javascript console.

Yes, you need to return the question including ids. But that also works, if you just read the $newOption after inserting. Just the same, as you do with the question above, which you also return including the new id.

		$question = Question::fromParams($destinationQuestion);
		$this->questionMapper->insert($question);

		$response = $question->read();
[ ... ]
			$newOption = Option::fromParams($optionData);
			$this->optionMapper->insert($newOption);

			$response['options'][$i] = $newOption->read();

[susnux]

Thank you again for this work, I took the liberty to squash your commits and pushed a commit fixing the remaining review comments.

[Chartman123]

@susnux we need to add the route to the docs as Jonas already mentioned :)

[susnux]

@Chartman123

we need to add the route to the docs as Jonas already mentioned :)

Yes this is resolved

[Chartman123]

Looks good in general :) Should we add a "Copy of " to the question title or something like that?

[susnux]

Should we add a "Copy of " to the question title or something like that?

I would say this does not make much sense for questions and would make the workflow more complex?

[Chartman123]

@susnux Squash the commits into one and then we're good to go :)