Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameter typing for extraSettings #1769

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

Chartman123
Copy link
Collaborator

No description provided.

@Chartman123 Chartman123 added php PHP related ticket 3. to review Waiting for reviews labels Oct 28, 2023
@Chartman123 Chartman123 added this to the 3.4 milestone Oct 28, 2023
@Chartman123 Chartman123 self-assigned this Oct 28, 2023
lib/Db/Question.php Outdated Show resolved Hide resolved
@Chartman123 Chartman123 changed the title Remove deprecated TODO Move parameter typing for extraSettings Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #1769 (0ed05d5) into main (390cac9) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1769   +/-   ##
=========================================
  Coverage     42.98%   42.98%           
  Complexity      614      614           
=========================================
  Files            58       58           
  Lines          2489     2489           
=========================================
  Hits           1070     1070           
  Misses         1419     1419           

lib/Db/Question.php Outdated Show resolved Hide resolved
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@susnux susnux merged commit c7a42ab into main Nov 7, 2023
21 checks passed
@susnux susnux deleted the chore-remove-deprecated-todo branch November 7, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants