Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:flagged icons position #10007

Merged
merged 1 commit into from
Aug 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/components/Envelope.vue
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
:class="{ 'important-one-line': oneLineLayout, 'icon-important': !oneLineLayout }"
:data-starred="isImportant ? 'true' : 'false'"
@click.prevent="hasWriteAcl ? onToggleImportant() : false"
v-html="importantSvg" />

Check warning on line 38 in src/components/Envelope.vue

View workflow job for this annotation

GitHub Actions / NPM lint

'v-html' directive can lead to XSS attack
<JunkIcon v-if="data.flags.$junk"
:size="18"
class="app-content-list-item-star junk-icon-style"
Expand Down Expand Up @@ -937,7 +937,7 @@
// In message list, but not the one in the action menu
&.app-content-list-item-star {
background-image: none;
left: 4px;
left: 5px;
top: 8px;
opacity: 1;

Expand All @@ -948,7 +948,8 @@
}
}
.important-one-line.app-content-list-item-star:deep() {
top: 3px !important;
top: 4px !important;
left: 2px;
}

.app-content-list-item-select-checkbox {
Expand Down Expand Up @@ -989,6 +990,9 @@
opacity: .1;
}
}
.one-line.junk-icon-style {
top: 36px;
}

.icon-attachment {
-ms-filter: 'progid:DXImageTransform.Microsoft.Alpha(Opacity=25)';
Expand Down Expand Up @@ -1037,8 +1041,8 @@
.app-content-list-item-star.favorite-icon-style {
display: inline-block;
position: absolute;
margin-bottom: 21px;
margin-left: 28px;
margin-bottom: 45px;
margin-left: 30px;
cursor: pointer;
stroke: var(--color-main-background);
stroke-width: 2;
Expand All @@ -1047,6 +1051,10 @@
opacity: .4;
}
}
.one-line.favorite-icon-style {
margin-bottom: 31px;
margin-left: 31px;
}
:deep(.svg svg) {
height: 16px;
width: 16px;
Expand Down
Loading