fix: send imip when importing an event in mail #9992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| existingEvent: this.existingEvent, | ||
| }) | ||
| } finally { | ||
| this.loading = false |
There was a problem hiding this comment.
I liked unsetting loading in finally because this was it is ensured that the reset happens even on error
There was a problem hiding this comment.
It still reset, just a few lines later. We have two try-catch blocks now, and both are wrapped in an if statement. First the loading state is enabled, then one or both try-catch statements run, and last the loading state is disabled.
The current loading state does not work because ButtonVue (an alias for NcButton) has no property called "loading". I've changed the code to disable the button and added the loading icon to the right.
miaulalala
approved these changes
Aug 13, 2024
1 task
An iMIP message for attendees is only generated when updating an existing event (cf. https://github.com/nextcloud/3rdparty/blob/ea2fabbd358c9e0f9dae43bcb242b0cf8ee0d178/sabre/vobject/lib/ITip/Broker.php#L245-L254). To also trigger an iMIP message from mail, we first import then event and update the attendance status afterward. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/noid/imip-for-external-organizers
branch
from
5c67f66
to
880eca7
Compare
ChristophWurst
approved these changes
Aug 21, 2024
|
/backport to stable3.4 |
2 tasks
|
/backport to stable3.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An iMIP message for attendees is only generated when updating an existing event (cf. https://github.com/nextcloud/3rdparty/blob/ea2fabbd358c9e0f9dae43bcb242b0cf8ee0d178/sabre/vobject/lib/ITip/Broker.php#L245-L254).
To also trigger an iMIP message from mail, we first import then event and update the attendance status afterward.
How to test