-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send imip when importing an event in mail #9992
Conversation
existingEvent: this.existingEvent, | ||
}) | ||
} finally { | ||
this.loading = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked unsetting loading in finally because this was it is ensured that the reset happens even on error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still reset, just a few lines later. We have two try-catch blocks now, and both are wrapped in an if statement. First the loading state is enabled, then one or both try-catch statements run, and last the loading state is disabled.
The current loading state does not work because ButtonVue (an alias for NcButton) has no property called "loading". I've changed the code to disable the button and added the loading icon to the right.
An iMIP message for attendees is only generated when updating an existing event (cf. https://github.com/nextcloud/3rdparty/blob/ea2fabbd358c9e0f9dae43bcb242b0cf8ee0d178/sabre/vobject/lib/ITip/Broker.php#L245-L254). To also trigger an iMIP message from mail, we first import then event and update the attendance status afterward. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
5c67f66
to
880eca7
Compare
/backport to stable3.4 |
/backport to stable3.7 |
Summary
An iMIP message for attendees is only generated when updating an existing event (cf. https://github.com/nextcloud/3rdparty/blob/ea2fabbd358c9e0f9dae43bcb242b0cf8ee0d178/sabre/vobject/lib/ITip/Broker.php#L245-L254).
To also trigger an iMIP message from mail, we first import then event and update the attendance status afterward.
How to test