Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-20.0] Last moderator should not leave the room #4419

Merged
merged 11 commits into from
Nov 5, 2024
Merged

[stable-20.0] Last moderator should not leave the room #4419

merged 11 commits into from
Nov 5, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 5, 2024

Backport of PR #4360

sowjanyakch and others added 11 commits November 5, 2024 14:29
@sowjanyakch @backportbot
Rename .java to .kt
a0be5fa 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
Convert LeaveConversationWorker from java to Kotlin
c0377a7 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
remove unused imports
ed5c9a0 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
Start unique work
a294030 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
handle workResult
621f9f7 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
make worker listenable
189b4e9 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
refresh main activity after leaving a conversation
185b42f 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
ktlintFormat
9028ad0 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
handle errors properly
bbcc3fb 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
add const val for error code
1bf55f9 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi @backportbot
set nc_last_moderator_leaving_room_warning to one line in strings.xml
f1d0709 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Nov 5, 2024
@backportbot backportbot bot added this to the 20.0.3 milestone Nov 5, 2024
@mahibi mahibi enabled auto-merge November 5, 2024 14:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4419-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Codacy

Lint

TypemasterPR
Warnings94150
Errors13286

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7978
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109108

Lint increased!

@mahibi mahibi merged commit e674d35 into stable-20.0 Nov 5, 2024
11 of 15 checks passed
@mahibi mahibi deleted the backport/4360/stable-20.0 branch November 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@mahibi mahibi Awaiting requested review from mahibi

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sowjanyakch @mahibi