Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress during check-setup #359

Open
corneliusroemer opened this issue Feb 1, 2024 · 1 comment
Open

Show progress during check-setup #359

corneliusroemer opened this issue Feb 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

nextstrain check-setup takes almost a minute despite having a fast M1 Pro. There's no progress indicator which might be confusing to users who are running it for the first time.

It might be good to give an indication how long this check takes. E.g. "Testing your setup... (this takes about a minute)"

Even better would be some sort of progress indication after each runtime is checked, maybe outputting it or indicating that it has been checked successfully.

image
@corneliusroemer corneliusroemer added the enhancement New feature or request label Feb 1, 2024
@tsibley
Copy link
Member

tsibley commented Feb 1, 2024

Yeah, check-setup hasn't gotten a lot of attention. It could use some!

tsibley added a commit that referenced this issue Feb 2, 2024
Conditions on the Nextstrain CLI version being requested, as aarch64
builds¹ will only be available going forward for new releases.  Assumes
the next release will be 8.2.0!

Disables Rosetta check when using an aarch64 build, as the checks will
be done at the runtime-level instead by `nextstrain setup` and
`nextstrain check-setup`.²

We must wait to merge this until after the first release (i.e. 8.2.0) of
the changes it depends on above.

¹ <#357>
² <#359>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants