You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This terminology was left as-is in #355 (nextstrain-pathogen.yaml) even as it got a little more nuanced: it's no longer "the directory which was passed to nextstrain build." The term "build" has also drifted out of phase from terminology in the wider ecosystem.
Review and revise existing usages to clarify them and extend them to include the behaviour around nextstrain-pathogen.yaml.
There's a pretty good description of the behaviour in the changelog for 8.2.0:
Here's some notes I made myself which may help others while the docs are forthcoming.
Example: we're in avian-flu running nextstrain --docker ingest.
Without nextstrain-pathogen.yaml
With nextstrain-pathogen.yaml
/nextstrain/build is
ingest
avian-flu
Starting directory
/nextstrain/build
/nextstrain/build/ingest
If we're in avian-flu/ingest and we run nextstrain --docker . the results are identical to above.
If we're in avian-flu and we run nextstrain --docker . then the presence of nextstrain-pathogen.yaml makes no difference.
When does this matter?
If you are using relative paths which track back to a higher directory than the one your workflow is in. For instance, avian-flu/ingest/Snakemake refers to the fauna location as ../fauna (src) and the repo doesn't define nextstrain-pathogen.yaml . Running this outside of docker doesn't work, as fauna isn't typically located at avian-flu/fauna . Using nextstrain --docker ingest works as we have nextstrain/fauna and nextstrain/build is the ingest dir.
This results in a different mount point for the 'ingest' directory in
docker runtimes which more closely matches a typical setup using other
runtimes. This allows the relative location of fauna ('path_to_fauna')
to be the same for a typical ambient setup as for docker.
See <nextstrain/cli#371 (comment)>
for more detail on mount points for the docker runtime.
This terminology was left as-is in #355 (
nextstrain-pathogen.yaml
) even as it got a little more nuanced: it's no longer "the directory which was passed tonextstrain build
." The term "build" has also drifted out of phase from terminology in the wider ecosystem.Review and revise existing usages to clarify them and extend them to include the behaviour around
nextstrain-pathogen.yaml
.There's a pretty good description of the behaviour in the changelog for 8.2.0:
cli/CHANGES.md
Lines 52 to 107 in 14a392e
Motivated by @jameshadfield's commentary in review of a separate change.
The text was updated successfully, but these errors were encountered: