-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass/mock ncbi datasets call in ci #46
Comments
The tradeoff is that we'll have to keep the example NCBI dataset file up-to-date with upstream changes, else we won't be testing what NCBI's actually providing and will drift over time.
Really? We rely on a ton of external services in CI, not just NCBI. I understand where you're coming from with not using external services, but I think it's unrealistic. |
It's great we are running ingest as part of pathogen ci.
But we shouldn't rely on external services in our CI. Right now, with our setup, if NCBI datasets is down, CI fails, because ingest includes a call to their infrastructure.
I think we should not use ncbi datasets in CI, and instead use an archived zip file that is identical to what datasets would produce.
Based on a comment on PR #45:
Originally posted by @corneliusroemer in #45 (review)
The text was updated successfully, but these errors were encountered: