-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARC transilable async/promise based IO #479
Conversation
src/ARCtrl/ARCtrl.Python.fsproj
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No pypackage reference for femto?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not using femot at all. Would be a to-do for the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Femto is for the people installing ARCtrl as it installs nuget and native dependencies.
We did it for the npm dependencies so i thought i make you aware of this
@@ -1,31 +1,52 @@ | |||
namespace ARCtrl | |||
namespace ARCtrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we keep one minimal arc in version control for testing?
Could we not write it first and therefore test correct writing too?
Then we could ommit the ARC from version control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some brainstorming: Maybe git-submodul the example arc from gitlab? So we can ensure being compatible with the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe git-submodul the example arc from gitlab?
This is what we do in the integration tests for arc validation packages, see submodule here, action that pulls submodules in CI here and tests if submodules are there here
(obviously, the test fixtures must be translated into pyxpecto, i don't know if it has that functionality)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, using the Prototype ARC would be the best solution.
Only using the ARCs written with the library might leave a blind spot for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rick roll?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not! Now i am surprised :D
emit
logicimport
logic