Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swate-template-registry #159

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

swate-template-registry #159

wants to merge 11 commits into from

Conversation

kMutagene
Copy link
Member

This serves as a draft PR for #158

Currently, i have a split between template metadata and content in the DB model, not sure if that is worth it as the json seems not that large.

@Freymaurer you should be able to run this locally in Visual Studio by running the docker compose project.

@Freymaurer
Copy link
Collaborator

Some screenshots from the service @StellaEggels

image

image

image

@StellaEggels
Copy link
Collaborator

Looks good! For the template content it might be nice to hide the TSR/TAN columns to give a better overview of the template. And I'm wondering if adding a "example values" label would be necessary to make clear that the filled row is just an example and doesn't have to be used.

@Freymaurer
Copy link
Collaborator

Looks good! For the template content it might be nice to hide the TSR/TAN columns to give a better overview of the template.

I had it like this before, but then the term ids are not shown. Not sure what should be valued higher

And I'm wondering if adding a "example values" label would be necessary to make clear that the filled row is just an example and doesn't have to be used.

I will add a note to it above!

@kMutagene
Copy link
Member Author

Small style suggestion, i think that subtle lines should be used here for better visual separation of columns

@Freymaurer
Copy link
Collaborator

Small style suggestion, i think that subtle lines should be used here for better visual separation of columns

Is there some pico.css class i can use? Or do i have to add borders myself?

@kMutagene
Copy link
Member Author

https://picocss.com/docs/table looks to me like that has to be custom css

@kMutagene
Copy link
Member Author

for clarity, i only would add this to the template table preview as that can be quite large

@Freymaurer
Copy link
Collaborator

Updated:
image

@StellaEggels
Copy link
Collaborator

Hi, what is the state of this? I think I would still prefer to hide the term IDs. I think the priority here should be to get a good overview of the template, the details can then be checked in Swate where the template can be modified if needed

@Freymaurer
Copy link
Collaborator

Hey i think the state progressed nicely. But we might need something like an oboarding session, because upload will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants