Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and attach acme.js to release #55

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Conversation

zsteinkamp
Copy link
Contributor

Proposed changes

Adds a Github action that runs on Release creation that builds acme.js and attaches it to the release.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Copy link
Collaborator

@ryepup ryepup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a path with fewer/zero action dependencies.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@zsteinkamp zsteinkamp merged commit 0168d36 into main Mar 29, 2024
4 checks passed
@zsteinkamp zsteinkamp deleted the zsteinkamp/publish-artifact branch March 29, 2024 17:18
@zsteinkamp
Copy link
Contributor Author

You rock, @ryepup !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants