added new action to build + push to azure #2152
Conversation
lamATnginx
force-pushed
the
chore/build-push
branch
from
436841e to
eed9d94
Compare
| @@ -0,0 +1,40 @@ | |||
| name: Build + Push to Azure | |||
There was a problem hiding this comment.
Can we add "docs" to this name (and the name of the file itself) so it's clear what this is for? (and not the product).
| branch: | ||
| description: "Source branch to deploy" | ||
| required: false | ||
| default: "main" |
There was a problem hiding this comment.
I think source branch should be required, and not default to main. This way someone doesn't accidentally publish our docs from the main branch, since we want our published docs to always be from a release branch.
| - prod | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Similar to the comment above, I'm assuming this is going to publish our public docs for every push to main? if so, we don't want that behavior, we only publish from our latest release branch.
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 96 96
Lines 6695 6695
Branches 50 50
=======================================
Hits 5866 5866
Misses 773 773
Partials 56 56 ☔ View full report in Codecov by Sentry. |
|
This PR was closed because it has been stalled for 14 days with no activity. |
Proposed changes
Problem: Due to the shift away from netlify to azure, the build must be updated to build + push to Azure.
Solution: Create a new action that is only triggered when docs related changes are made.
Testing: Manual testing to ensure build is correct and triggered as defined in
Solution.Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.