Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty configuation when tests run by Rider #151

Merged
merged 4 commits into from
May 11, 2024
Merged

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented May 7, 2024

Rider has own test runner (ReSharperTestRunner.dll), so Assembly.GetEntryAssembly() is not "testhost.dll". When trying to remove the check for "testhost", then it started failing with access denied exception to Rider's installation path.

@hazzik hazzik changed the title Fix configuring tests when run in Rider Fix configuring tests when run tests in Rider May 7, 2024
@hazzik hazzik changed the title Fix configuring tests when run tests in Rider Fix empty configuation when tests run by Rider May 7, 2024
@fredericDelaporte fredericDelaporte added this to the 5.9.1 milestone May 9, 2024
fredericDelaporte

This comment was marked as outdated.

Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well actually, I was not testing on the right branch and that is current master which fails with VS and net6, while your version works.

@hazzik hazzik enabled auto-merge (squash) May 10, 2024 03:03
@hazzik hazzik merged commit f7c21b9 into master May 11, 2024
3 of 4 checks passed
@hazzik hazzik deleted the fix-tests-rider branch May 11, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants