Fix combining cascades

Fixes #472 +semver:fix
nhibernate · Oct 9, 2020 · e4c6e16 · e4c6e16
1 parent 3b66ce6
commit e4c6e16
Show file tree

Hide file tree

Showing 9 changed files with 67 additions and 13 deletions.
diff --git a/src/FluentNHibernate.Testing/FluentInterfaceTests/AnyMutablePropertyModelGenerationTests.cs b/src/FluentNHibernate.Testing/FluentInterfaceTests/AnyMutablePropertyModelGenerationTests.cs
@@ -33,6 +33,18 @@ public void CascadeSetsModelCascadePropertyToValue()
                 .ModelShouldMatch(x => x.Cascade.ShouldEqual("all"));
         }
 
+        [Test]
+        public void CascadeAppendModelCascadePropertyToValue()
+        {
+            Any<SecondMappedObject>()
+                .Mapping(m => m
+                    .IdentityType<int>()
+                    .EntityIdentifierColumn("col")
+                    .EntityTypeColumn("col2")
+                    .Cascade.Merge().Cascade.SaveUpdate())
+                .ModelShouldMatch(x => x.Cascade.ShouldEqual("merge,save-update"));
+        }
+
         [Test]
         public void IdentityTypeSetsModelIdTypePropertyToPropertyTypeName()
         {

diff --git a/...rnate.Testing/FluentInterfaceTests/HibernateMappingMutablePropertyModelGenerationTests.cs b/...rnate.Testing/FluentInterfaceTests/HibernateMappingMutablePropertyModelGenerationTests.cs
@@ -37,6 +37,14 @@ public void DefaultCascadeShouldSetModelDefaultCascadePropertyToValue()
                 .ModelShouldMatch(x => x.DefaultCascade.ShouldEqual("all"));
         }
 
+        [Test]
+        public void DefaultCascadeShouldAppendModelDefaultCascadePropertyToValue()
+        {
+            HibernateMapping()
+                .Mapping(m => { m.DefaultCascade.Merge(); m.DefaultCascade.SaveUpdate(); })
+                .ModelShouldMatch(x => x.DefaultCascade.ShouldEqual("merge,save-update"));
+        }
+
         [Test]
         public void DefaultLazyShouldSetModelDefaultLazyPropertyToTrue()
         {

diff --git a/...tNHibernate.Testing/FluentInterfaceTests/ManyToManyMutablePropertyModelGenerationTests.cs b/...tNHibernate.Testing/FluentInterfaceTests/ManyToManyMutablePropertyModelGenerationTests.cs
@@ -52,6 +52,14 @@ public void CascadeShouldSetModelCascadePropertyToValue()
                 .ModelShouldMatch(x => x.Cascade.ShouldEqual("all"));
         }
 
+        [Test]
+        public void CascadeShouldAppendModelCascadePropertyToValue()
+        {
+            ManyToMany(x => x.BagOfChildren)
+                .Mapping(m => { m.Cascade.SaveUpdate(); m.Cascade.Merge(); })
+                .ModelShouldMatch(x => x.Cascade.ShouldEqual("save-update,merge"));
+        }
+
         [Test]
         public void CollectionTypeShouldSetModelCollectionTypePropertyToValue()
         {

diff --git a/...entNHibernate.Testing/FluentInterfaceTests/OneToOneMutablePropertyModelGenerationTests.cs b/...entNHibernate.Testing/FluentInterfaceTests/OneToOneMutablePropertyModelGenerationTests.cs
@@ -33,21 +33,37 @@ public void ClassShouldSetModelClassPropertyToValue()
         }
 
         [Test]
-        public void CascadeShouldSetModelCascadePropertyToTrue()
+        public void ConstrainedShouldSetModelConstrainedPropertyToTrue()
         {
             OneToOne()
                 .Mapping(m => m.Constrained())
                 .ModelShouldMatch(x => x.Constrained.ShouldBeTrue());
         }
 
         [Test]
-        public void NotCascadeShouldSetModelCascadePropertyToFalse()
+        public void NotConstrainedShouldSetModelConstrainedPropertyToFalse()
         {
             OneToOne()
                 .Mapping(m => m.Not.Constrained())
                 .ModelShouldMatch(x => x.Constrained.ShouldBeFalse());
         }
 
+        [Test]
+        public void CascadeSetsModelCascadePropertyToValue()
+        {
+            OneToOne()
+                .Mapping(m => m.Cascade.All())
+                .ModelShouldMatch(x => x.Cascade.ShouldEqual("all"));
+        }
+
+        [Test]
+        public void CascadeAppendModelCascadePropertyToValue()
+        {
+            OneToOne()
+                .Mapping(m => { m.Cascade.Merge(); m.Cascade.SaveUpdate(); })
+                .ModelShouldMatch(x => x.Cascade.ShouldEqual("merge,save-update"));
+        }
+
         [Test]
         public void FetchShouldSetModelFetchPropertyToValue()
         {

diff --git a/src/FluentNHibernate/Mapping/AnyPart.cs b/src/FluentNHibernate/Mapping/AnyPart.cs
@@ -31,7 +31,11 @@ public AnyPart(Type entity, Member member)
             this.entity = entity;
             this.member = member;
             access = new AccessStrategyBuilder<AnyPart<T>>(this, value => attributes.Set("Access", Layer.UserSupplied, value));
-            cascade = new CascadeExpression<AnyPart<T>>(this, value => attributes.Set("Cascade", Layer.UserSupplied, value));
+            cascade = new CascadeExpression<AnyPart<T>>(this, value =>
+            {
+                var current = attributes.Get("Cascade") as string;
+                attributes.Set("Cascade", Layer.UserSupplied, current == null ? value : string.Format("{0},{1}", current, value));
+            });
 
             SetDefaultAccess();
         }

diff --git a/src/FluentNHibernate/Mapping/HibernateMappingPart.cs b/src/FluentNHibernate/Mapping/HibernateMappingPart.cs
@@ -13,7 +13,11 @@ public class HibernateMappingPart : IHibernateMappingProvider
 
         public HibernateMappingPart()
         {
-            defaultCascade = new CascadeExpression<HibernateMappingPart>(this, value => attributes.Set("DefaultCascade", Layer.UserSupplied, value));
+            defaultCascade = new CascadeExpression<HibernateMappingPart>(this, value =>
+            {
+                var current = attributes.Get("DefaultCascade") as string;
+                attributes.Set("DefaultCascade", Layer.UserSupplied, current == null ? value : string.Format("{0},{1}", current, value));
+            });
             defaultAccess = new AccessStrategyBuilder<HibernateMappingPart>(this, value => attributes.Set("DefaultAccess", Layer.UserSupplied, value));
         }
 

diff --git a/src/FluentNHibernate/Mapping/OneToManyPart.cs b/src/FluentNHibernate/Mapping/OneToManyPart.cs
@@ -12,7 +12,6 @@ public class OneToManyPart<TChild> : ToManyBase<OneToManyPart<TChild>, TChild>
     {
         private readonly Type entity;
         private readonly ColumnMappingCollection<OneToManyPart<TChild>> keyColumns;
-        private readonly CollectionCascadeExpression<OneToManyPart<TChild>> cascade;
         private readonly NotFoundExpression<OneToManyPart<TChild>> notFound;
         private IndexManyToManyPart manyToManyIndex;
         private readonly Type childType;
@@ -31,11 +30,6 @@ protected OneToManyPart(Type entity, Member member, Type collectionType)
             childType = collectionType;
 
             keyColumns = new ColumnMappingCollection<OneToManyPart<TChild>>(this);
-            cascade = new CollectionCascadeExpression<OneToManyPart<TChild>>(this, value =>
-            {
-                var current = collectionAttributes.Get("Cascade") as string;
-                collectionAttributes.Set("Cascade", Layer.UserSupplied, current == null ? value : string.Format("{0},{1}", current, value));
-            });
             notFound = new NotFoundExpression<OneToManyPart<TChild>>(this, value => relationshipAttributes.Set("NotFound", Layer.UserSupplied, value));
 
             collectionAttributes.Set("Name", Layer.Defaults, member.Name);
@@ -54,7 +48,7 @@ public NotFoundExpression<OneToManyPart<TChild>> NotFound
         /// </summary>
         public new CollectionCascadeExpression<OneToManyPart<TChild>> Cascade
         {
-            get { return cascade; }
+            get { return base.Cascade; }
         }
 
         /// <summary>

diff --git a/src/FluentNHibernate/Mapping/OneToOnePart.cs b/src/FluentNHibernate/Mapping/OneToOnePart.cs
@@ -21,7 +21,11 @@ public OneToOnePart(Type entity, Member member)
         {
             access = new AccessStrategyBuilder<OneToOnePart<TOther>>(this, value => attributes.Set("Access", Layer.UserSupplied, value));
             fetch = new FetchTypeExpression<OneToOnePart<TOther>>(this, value => attributes.Set("Fetch", Layer.UserSupplied, value));
-            cascade = new CascadeExpression<OneToOnePart<TOther>>(this, value => attributes.Set("Cascade", Layer.UserSupplied, value));
+            cascade = new CascadeExpression<OneToOnePart<TOther>>(this, value =>
+            {
+                var current = attributes.Get("Cascade") as string;
+                attributes.Set("Cascade", Layer.UserSupplied, current == null ? value : string.Format("{0},{1}", current, value));
+            });
             this.entity = entity;
             this.member = member;
 

diff --git a/src/FluentNHibernate/Mapping/ToManyBase.cs b/src/FluentNHibernate/Mapping/ToManyBase.cs
@@ -36,7 +36,11 @@ protected ToManyBase(Type entity, Member member, Type type)
             AsBag();
             access = new AccessStrategyBuilder<T>((T)this, value => collectionAttributes.Set("Access", Layer.UserSupplied, value));
             fetch = new FetchTypeExpression<T>((T)this, value => collectionAttributes.Set("Fetch", Layer.UserSupplied, value));
-            cascade = new CollectionCascadeExpression<T>((T)this, value => collectionAttributes.Set("Cascade", Layer.UserSupplied, value));
+            cascade = new CollectionCascadeExpression<T>((T)this, value =>
+            {
+                var current = collectionAttributes.Get("Cascade") as string;
+                collectionAttributes.Set("Cascade", Layer.UserSupplied, current == null ? value : string.Format("{0},{1}", current, value));
+            });
 
             SetDefaultCollectionType();
             SetCustomCollectionType(type);