Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded Home link from navigation #986

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove hardcoded Home link from navigation #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e0a1d5
Remove hardcoded Home link from navigation
frankieroberto Jul 17, 2024
ad10e05
Add 'Home' to examples
frankieroberto Jul 17, 2024
f7514de
Merge branch 'main' into remove-home-from-header-navigation
frankieroberto Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/header/header-navigation.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@
{
'url' : 'https://www.nhs.uk/nhs-services/',
'label' : 'NHS services'
},
{
'url' : 'https://www.nhs.uk/',
'label' : 'Home',
'classes': 'nhsuk-header__navigation-item--home'
}
]
})
Expand Down
5 changes: 5 additions & 0 deletions app/components/header/header-service-name-with-nav.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
{
'url' : '#',
'label' : 'Community and contribution'
},
{
'url' : 'https://www.nhs.uk/',
'label' : 'Home',
'classes': 'nhsuk-header__navigation-item--home'
}
]
})
Expand Down
10 changes: 0 additions & 10 deletions packages/components/header/template.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,6 @@
</a>
</li>
{%- endfor %}
<li class="nhsuk-header__navigation-item nhsuk-header__navigation-item--home">
<a class="nhsuk-header__navigation-link" href="/">
Home
</a>
</li>
<li class="nhsuk-mobile-menu-container">
<button class="nhsuk-header__menu-toggle nhsuk-header__navigation-link" id="toggle-menu" aria-expanded="false">
<span class="nhsuk-u-visually-hidden">Browse</span>
Expand Down Expand Up @@ -146,11 +141,6 @@
</a>
</li>
{%- endfor %}
<li class="nhsuk-header__navigation-item nhsuk-header__navigation-item--home">
<a class="nhsuk-header__navigation-link" href="/">
Home
</a>
</li>
<li class="nhsuk-mobile-menu-container">
<button class="nhsuk-header__menu-toggle nhsuk-header__navigation-link" id="toggle-menu" aria-expanded="false">
<span class="nhsuk-u-visually-hidden">Browse</span>
Expand Down
Loading