Skip to content

Commit

Permalink
fix(dataframe): switch orientation of metadata frame
Browse files Browse the repository at this point in the history
  • Loading branch information
mure committed Nov 6, 2023
1 parent 2d2412f commit f9ce83e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
10 changes: 3 additions & 7 deletions src/datasources/data-frame/DataFrameDataSource.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ it('returns table properties for metadata query', async () => {

expect(fetchMock).toHaveBeenCalledWith(expect.objectContaining({ url: '_/nidataframe/v1/tables/1' }));
expect(response.data[0].fields).toEqual([
{ name: 'name', values: ['hello', 'foo'] },
{ name: 'value', values: ['world', 'bar'] },
{ name: 'hello', values: ['world'] },
{ name: 'foo', values: ['bar'] },
])
});

Expand All @@ -253,12 +253,8 @@ it('handles metadata query when table has no properties', async () => {

const response = await ds.query(query);

console.log(fetchMock.mock.calls)
expect(fetchMock).toHaveBeenCalledWith(expect.objectContaining({ url: '_/nidataframe/v1/tables/2' }));
expect(response.data[0].fields).toEqual([
{ name: 'name', values: [] },
{ name: 'value', values: [] },
])
expect(response.data[0].fields).toEqual([]);
});

const buildQuery = (targets: DataFrameQuery[]): DataQueryRequest<DataFrameQuery> => {
Expand Down
5 changes: 1 addition & 4 deletions src/datasources/data-frame/DataFrameDataSource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,7 @@ export class DataFrameDataSource extends DataSourceBase<DataFrameQuery> {
return {
refId: processedQuery.refId,
name: metadata.name,
fields: [
{ name: 'name', values: Object.keys(metadata.properties) },
{ name: 'value', values: Object.values(metadata.properties) },
],
fields: Object.entries(metadata.properties).map(([name, value]) => ({ name, values: [value] })),
};
} else {
const columns = this.getColumnTypes(processedQuery.columns, metadata?.columns ?? []);
Expand Down

0 comments on commit f9ce83e

Please sign in to comment.