feat(tag): retry requests for 429 error #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronwaterman
approved these changes
Sep 15, 2023
mure
pushed a commit
that referenced
this pull request
Sep 15, 2023
## [3.1.0](v3.0.2...v3.1.0) (2023-09-15) ### Features * **tag:** retry requests for 429 error ([#30](#30)) ([48f664c](48f664c))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
https://dev.azure.com/ni/DevCentral/_workitems/edit/2523281
The tag plugin is likely to get throttled when making a lot of history requests.
👩💻 Implementation
There's a few ways to approach this, but retrying failed requests is the easiest to implement, works even if a user has multiple dashboards open, and can be reused across all our plugins.
The strategy I've applied is to retry a maximum of 3 times with an exponential backoff (1, 2, 4 seconds). The actual delay for each request will be randomized to introduce jitter.
🧪 Testing
Unfortunately, the mild amount of refactoring from this change did force us to have to rewrite all the tests a bit. I also added two new tests for the retry behavior.
✅ Checklist