Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-frame): Data Frame data source displays associated Workspace #40

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

cameronwaterman
Copy link
Collaborator

Pull Request

🀨 Rationale

https://dev.azure.com/ni/DevCentral/_workitems/edit/2527389

πŸ‘©β€πŸ’» Implementation

Show Data Table Workspace name as description text is Data Table selection drop-down and move the ID to title (hover text). This involved needing to migrate the Data Table data source to extend DataSourceBase.

πŸ§ͺ Testing

Tests continue to pass.

βœ… Checklist

Copy link
Collaborator

@mure mure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the refactor to extend from DataSourceBase. Glad to see that we didn't have to modify the tests at all.

src/core/DataSourceBase.ts Outdated Show resolved Hide resolved
@cameronwaterman cameronwaterman merged commit 7dfc0c5 into main Sep 28, 2023
1 check passed
@cameronwaterman cameronwaterman deleted the users/cwaterma/df-ds-display-workspace branch September 28, 2023 14:39
mure pushed a commit that referenced this pull request Sep 28, 2023
## [3.3.0](v3.2.1...v3.3.0) (2023-09-28)

### Features

* **data-frame:** Data Frame data source displays associated Workspace ([#40](#40)) ([7dfc0c5](7dfc0c5))
@mure
Copy link
Collaborator

mure commented Sep 28, 2023

πŸŽ‰ This PR is included in version 3.3.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants