feat(tag): include properties in query result #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronwaterman
approved these changes
Oct 5, 2023
mure
pushed a commit
that referenced
this pull request
Oct 6, 2023
## [3.6.0](v3.5.0...v3.6.0) (2023-10-06) ### Features * **tag:** include properties in query result ([#42](#42)) ([0ffc1e2](0ffc1e2))
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
https://dev.azure.com/ni/DevCentral/_workitems/edit/2504597
👩💻 Implementation
Pretty straightforward -
TagQueryEditornow has anInlineSwitchcomponent that lets users toggle whether or not to show properties. InTagDataSource, we map the tag's properties to DataFrame fields and conditionally append them to the result. We ignore properties that start with "nitag" because they're used by the historian service and not useful to users. We also now return the tag's last updated timestamp for the "Current" query mode.🧪 Testing
I decided to make the leap to using snapshot testing for some of the tag data source tests. I've been thinking about it for a while, but this change made updating the test assertions tedious enough that I tried it out. It's really nice for testing the data source
querymethod. Instead of manually typing out the expected result, Jest generates a snapshot file for us that stores the results. Then in the future if the snapshot changes, the test will fail.✅ Checklist